NameError: name 'ultrasonicRead' is not defined

pippi · March 22, 2015, 6:23am

Hi,

it’s my second day on GrovePi and i love it. I have a Raspberry Pi B+ with GrovePi+ with latest firmware 1.2.2 and library updated as suggested, by attaching the Ultrasonic Ranger to D4 and running sudo python grove_ultrasonic.py i get:
Traceback (most recent call last):
File “grove_ultrasonic.py”, line 13, in <module>
print ultrasonicRead(ultrasonic_ranger)
NameError: name ‘ultrasonicRead’ is not defined

I have no clue on why it doesn’t work. Any suggestion please?
Thanks

pippi · March 22, 2015, 7:08am

Okay, i got it.
changed “import grovepi” to “from grovepi import *” as seen in (working) Project file. Is this an issue i can open on github or are there specific reason why it behaves this way? Useful in case i find similar bugs.

mcauser · March 22, 2015, 5:08pm

“import grovepi” means you can use method grovepi.foo()

“from grovepi import” means you can use foo() instead of grovepi.foo().

Stack overflow discussion about it:

There is a bug in here:

github.com

DexterInd/GrovePi/blob/master/Software/Python/grove_ultrasonic.py

#!/usr/bin/env python
#
# GrovePi Example for using the Grove Ultrasonic Ranger (http://www.seeedstudio.com/wiki/Grove_-_Ultrasonic_Ranger)
#
# The GrovePi connects the Raspberry Pi and Grove sensors.  You can learn more about GrovePi here:  http://www.dexterindustries.com/GrovePi
#
# Have a question about this example?  Ask on the forums here:  http://forum.dexterindustries.com/c/grovepi
#
'''
## License

The MIT License (MIT)

GrovePi for the Raspberry Pi: an open source platform for connecting Grove Sensors to the Raspberry Pi.
Copyright (C) 2017  Dexter Industries

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell

This file has been truncated. show original

To match the other examples, it should be:
print grovepi.ultrasonicRead()

If you want to contribute the fix, create a fork, commit your fix and create a pull request.

Otherwise, if this all sounds too hard, I can do it.

pippi · March 23, 2015, 4:55am

Thanks for the clarification mcauser. By your suggestion i created my first pull request on github. Have a nice day

JohnC · March 23, 2015, 9:21am

Excellent! And thank you for the contribution! Just approved the pull, great work!